fix: Make PI heating demand from zhc.Climate writable in Home Assistant
#29188
+89
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Oct 20, 2025
lib/extension/homeassistant.ts
Outdated
| discoveryEntry.type = "number"; | ||
| discoveryEntry.discovery_payload = { | ||
| ...discoveryEntry.discovery_payload, | ||
| ...{ |
There was a problem hiding this comment.
I don't think the spread is needed here, same for entity_category: "diagnostic", below
There was a problem hiding this comment.
I removed the spread syntax. Needs the assert(discoveryEntry.discovery_payload) command before as discovery_payload may theoretically be empty due to the Partial<DiscoveryEntry>. I wanted to avoid the assert, that's why I've chosen the spread syntax before.
|
Thanks again @DerDreschner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
zhc.Climatefeature exposed thepi_heating_demandattribute as read-only attribute. This didn't changed when I make the attribute writable in zigbee-herdsman-converters with this change.Therefore, this pull requests makes the
pi_heating_demandwritable when the access state isSET. Additionally, I've added integration tests for both conditions.This matches the ZCL specifications: