fix: switching between zh and en bug #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuluo-yx
reviewed
Jun 22, 2025
| console/atest-desktop/coverage | ||
| atest-store-git | ||
| .db | ||
| .marscode/ |
There was a problem hiding this comment.
Usually, we put a new line at the end of each file. You can search the reason in Google.
There was a problem hiding this comment.
ok,I will search it.
yuluo-yx
reviewed
Jun 22, 2025
tools/make/common.mk
Outdated
| @echo -e "Usage:\n make \033[36m<Target>\033[0m \033[36m<Option>\033[0m\n\nTargets:" | ||
| @awk 'BEGIN {FS = ":.*##"; printf ""} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-15s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) | ||
| @echo -e "\n$$USAGE_OPTIONS" | ||
|
|
There was a problem hiding this comment.
IMO, this mk target more appropriate to put it in golang .mk
There was a problem hiding this comment.
Thank you for your correction. I will read the code carefully again.
LinuxSuRen
added
bug
LinuxSuRen
changed the title
LinuxSuRen
requested changes
Jun 22, 2025
tools/make/common.mk
Outdated
Comment on lines
126
to
128
| .PHONY: fmt | ||
| fmt: | ||
| go fmt ./... |
There was a problem hiding this comment.
It already exists. You can find it from golang.mk
There was a problem hiding this comment.
So, what is your pre-commit hook command?
|
LinuxSuRen
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix:switching between zh and en bug
What this PR does / why we need it:
This PR enables real-time switching from English to Chinese without requiring a page refresh. In addition, the modification to console/atest-ui/src/views/TestSuite.vue addresses a warning that appeared during npm run dev.
Because I have configured a pre-commit hook, the following error occurred during commit:
To fix this, I modified
tools/make/common.mkto recursively format all Go files under the current directory and its subdirectories.Which issue(s) this PR fixes:
Fixes # issues/710