forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
area-environmentsFeatures relating to handling interpreter environmentsFeatures relating to handling interpreter environmentsdebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
Description
This will involve the following:
- change
PythonExecutionService.pythonPath(a string) toPythonExecutionService.pyArgv(an array of strings)- https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonProcess.ts
- rename
- update
PythonExecutionServiceaccordingly
- update
PythonExecutionService.create()to pass an array of strings toPythonExecutionService()- https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonExecutionFactory.ts
- determine if conda or not (and set
pyArgvaccordingly) - update the call sites
- update
PythonExecutionService.createActivatedEnvironment()to pass an array of strings toPythonExecutionService()- https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonExecutionFactory.ts
- determine if conda or not (and set
pyArgvaccordingly) - update the call sites
- verify that the usage in the various places works properly for conda and non-conda:
- formatting
src/client/formatters/baseFormatter.ts(viaPythonToolExecutionService)
- linting
src/client/linters/errorHandlers/notInstalled.tssrc/client/linters/baseLinter.ts(viaPythonToolExecutionService)
- testing
src/client/testing/common/services/discovery.tssrc/client/testing/common/runner.tssrc/client/testing/common/runner.ts(viaPythonToolExecutionService)
- installers
src/client/common/installer/pipInstaller.tssrc/client/common/installer/productInstaller.ts
- debugger
src/client/debugger/extension/adapter/factory.ts
- interpreter discovery
src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.tssrc/client/interpreter/configuration/pythonPathUpdaterService.tssrc/client/interpreter/helpers.tssrc/client/interpreter/interpreterService.tssrc/client/interpreter/locators/services/windowsStoreInterpreter.ts
- import sorting
src/client/providers/importSortProvider.ts
- jedi
src/client/providers/jediProxy.ts
- refactoring
src/client/refactor/proxy.ts
- formatting
Metadata
Metadata
Assignees
Labels
area-environmentsFeatures relating to handling interpreter environmentsFeatures relating to handling interpreter environmentsdebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.