Add FP16 support to batchedNMSPlugin #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pbridger. Can you please sign your commits with |
rajeevsrao
added
Module:Plugins
|
@rajeevsrao Does this need to be integrated into master as well? |
Yes, but we will cherry-pick it internally first, test and release to master via 21.0x and then merge this change. |
pranavm-nvidia
approved these changes
Jan 13, 2021
Signed-off-by: Tyler Zhu <tylerz@nvidia.com> Signed-off-by: Paul Bridger <paul@paulbridger.com>
Signed-off-by: Paul Bridger <paul@paulbridger.com>
Signed-off-by: Paul Bridger <paul@paulbridger.com>
Signed-off-by: Paul Bridger <paul@paulbridger.com>
Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com> Signed-off-by: Paul Bridger <paul@paulbridger.com>
rajeevsrao
approved these changes
Jan 14, 2021
|
Thanks @pbridger. Will merge this commit once the corresponding cherry-pick for master is posted alongwith the 21.02 container update. |
|
Cool! Many thanks @rajeevsrao and @pranavm-nvidia for all your work to include this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for float16 boxes and scores (but not mixed precision between boxes and scores).
Gives inference results within expected numerical tolerances using SSD300 and COCO2017 validation set. (As detailed here https://paulbridger.com/posts/tensorrt-object-detection-quantized/).
Despite the "#if CUDA_ARCH >= 800" this has not been tested on Ampere, only Turing arch.