KEMBAR78
fix cancel request logic by QiJune · Pull Request #5800 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

fix cancel request logic #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 14, 2025
Merged

fix cancel request logic #5800

merged 15 commits into from
Jul 14, 2025

Conversation

@QiJune
Copy link
Collaborator

@QiJune QiJune commented Jul 7, 2025

Cherry-pick #5532 and move broadcasting cancel ids logic into _fetch_new_requests.

@QiJune
fix cancel request logic
d92a9c3 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune QiJune requested a review from a team as a code owner July 7, 2025 15:58
@QiJune QiJune requested a review from shaharmor98 July 7, 2025 15:58
@QiJune
polish
c6a69e2 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
Copy link
Collaborator Author

QiJune commented Jul 7, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11165 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11165 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8258 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@QiJune
put canceled request to request queue
36e52be 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
Copy link
Collaborator Author

QiJune commented Jul 8, 2025

/bot run

HuiGao-NV
HuiGao-NV approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@HuiGao-NV HuiGao-NV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QiJune QiJune requested a review from Shunkangz July 8, 2025 06:58
QiJune
QiJune commented Jul 8, 2025
View reviewed changes
@QiJune
Copy link
Collaborator Author

QiJune commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11239 [ run ] triggered by Bot

@Shunkangz Shunkangz mentioned this pull request Jul 8, 2025
Closed
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11239 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8313 completed with status: 'FAILURE'

QiJune added 6 commits July 8, 2025 21:30
@QiJune
Merge branch 'main' into fix_cancel
dd919c0
@QiJune
Merge branch 'main' into fix_cancel
ae2f753
@QiJune
add waiting queue
70d1a5a 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
polish
0d3083e 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
fix
9ff90fd 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>

fix

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>

fix

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>

fix

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
fix
140eb18 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
Copy link
Collaborator Author

QiJune commented Jul 11, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11617 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11617 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8610 completed with status: 'FAILURE'

QiJune added 2 commits July 11, 2025 19:39
@QiJune
fix
b5eb401 
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune
Merge branch 'main' into fix_cancel
d5f86cb
@QiJune
Copy link
Collaborator Author

QiJune commented Jul 11, 2025

/bot run

@QiJune
Copy link
Collaborator Author

QiJune commented Jul 12, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11686 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11686 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8653 completed with status: 'FAILURE'

@QiJune
Copy link
Collaborator Author

QiJune commented Jul 13, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11726 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11726 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8681 completed with status: 'SUCCESS'

@kaiyux kaiyux merged commit ce39409 into NVIDIA:main Jul 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shunkangz Shunkangz Shunkangz approved these changes

@HuiGao-NV HuiGao-NV HuiGao-NV approved these changes

@shaharmor98 shaharmor98 Awaiting requested review from shaharmor98 shaharmor98 is a code owner automatically assigned from NVIDIA/trt-llm-torch-runtime-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@QiJune @tensorrt-cicd @Shunkangz @HuiGao-NV @kaiyux