[None][feat] Enable gpt oss on DGX H100. #6775
Conversation
📝 WalkthroughWalkthroughAdds a DGX_H100 4-GPU PyTorch GPT_Oss test config, adds mako arg injection for stage names containing Changes
Sequence Diagram(s)sequenceDiagram
participant Jenkins
participant launchTestJobs
participant x86TestConfigs
participant getMakoArgsFromStageName
participant K8sPod
Jenkins->>launchTestJobs: Trigger test run
launchTestJobs->>x86TestConfigs: Read test configs
x86TestConfigs-->>launchTestJobs: Return DGX_H100-4_GPUs-PyTorch-GptOss-1
launchTestJobs->>getMakoArgsFromStageName: Build mako args for stage
getMakoArgsFromStageName-->>launchTestJobs: Include auto_trigger=gpt_oss (if -GptOss-)
launchTestJobs->>K8sPod: Create pod with 4 GPUs and start stage
K8sPod-->>Jenkins: Execute test stage and report status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run --disable-fail-fast --add-multi-gpu-test |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/L0_Test.groovy(1 hunks)
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)
1765-1765: LGTM: Stage entry is well-formed and consistent with schema
- Name segments and ordering align with existing patterns.
- Platform/yaml match other DGX_H100 entries.
- GPU count 4 matches type "dgx-h100-x4" and will provision 4 GPUs.
|
PR_Github #14739 [ run ] triggered by Bot |
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #14745 [ run ] triggered by Bot |
|
PR_Github #14739 [ run ] completed with state |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
jenkins/L0_MergeRequest.groovy (1)
624-633: Harden against null entries in changedFileListIn rare cases, changedFileList can contain nulls (e.g., from API variations), and file.startsWith(...) would NPE. Cheap guard:
- for (file in changedFileList) { + for (def file in changedFileList) { for (String key : specialFileToTagMap.keySet()) { - if (file.startsWith(key)) { + if (file?.startsWith(key)) { autoTriggerTagList += specialFileToTagMap[key] } } }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_MergeRequest.groovy(1 hunks)jenkins/L0_Test.groovy(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- jenkins/L0_Test.groovy
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/L0_MergeRequest.groovy (2)
626-627: Auto-trigger tag mapping for GPT_Oss is correctThe mapping to "-GptOss-" for modeling_gpt_oss.py aligns with the tag-driven trigger mechanism used elsewhere (e.g., DeepSeek). Good addition.
624-627: Cross-file integration verified for “-GptOss-”All checks pass—no further action required.
- The modeling file exists at
tensorrt_llm/_torch/models/modeling_gpt_oss.py.- L0_Test.groovy contains the
stageName.contains("-GptOss-")branch.getMakoArgsFromStageNamecorrectly addsauto_trigger=gpt_ossfor “-GptOss-”.- The
DGX_H100-4_GPUs-PyTorch-GptOss-1test configuration is defined.
|
PR_Github #14745 [ run ] completed with state |
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #14801 [ run ] triggered by Bot |
|
PR_Github #14801 [ run ] completed with state |
|
/bot run --add-multi-gpu-test |
|
PR_Github #14872 [ run ] triggered by Bot |
|
PR_Github #14872 [ run ] completed with state |
|
/bot run --add-multi-gpu-test |
|
PR_Github #15143 [ run ] triggered by Bot |
|
/bot run --add-multi-gpu-test |
|
PR_Github #15510 [ run ] triggered by Bot |
|
PR_Github #15510 [ run ] completed with state |
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Tracin
force-pushed
the
enable_gpt_oss_h100
branch
from
49b58a2 to
81244a0
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #19476 [ run ] triggered by Bot |
|
PR_Github #19476 [ run ] completed with state |
|
/bot run --add-multi-gpu-test |
|
PR_Github #19502 [ run ] triggered by Bot |
|
PR_Github #19502 [ run ] completed with state |
|
/bot run --help |
|
bot run --stage-list "DGX_H100-4_GPUs-PyTorch-GptOss-1" |
|
PR_Github #19538 Bot args parsing error: usage: /bot [-h] |
|
/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-GptOss-1" |
|
PR_Github #19541 [ run ] triggered by Bot |
|
PR_Github #19541 [ run ] completed with state |
|
/bot run |
|
PR_Github #19639 [ run ] triggered by Bot |
|
PR_Github #19639 [ run ] completed with state |
4 participants
Summary by CodeRabbit
Description
DGX-H100 GPTOSS is not enabled in #6732
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.