KEMBAR78
[None][ci] move all B200 TensorRT test cases to post merge by QiJune · Pull Request #7165 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@QiJune
Copy link
Collaborator

@QiJune QiJune commented Aug 22, 2025

Summary by CodeRabbit

  • Tests
    • Moved B200 PCIe TensorRT tests from pre-merge to post-merge in the CI pipeline.
    • Updated CI job mappings and test list to reflect the new stage; no changes to test configurations or coverage.
    • PyTorch tests remain in pre-merge.
    • Impact: shifts execution of these TensorRT tests to occur after merges, reducing pre-merge gating time while preserving test validation post-merge.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune QiJune requested review from a team as code owners August 22, 2025 09:56
@QiJune QiJune requested review from xinhe-nv and zeroepoch August 22, 2025 09:56
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

📝 Walkthrough

Walkthrough

The Jenkins CI configuration updates move B200 PCIe TensorRT tests from pre-merge to post-merge. Corresponding test list YAML updates change the TensorRT test stage to post_merge, leaving PyTorch tests as pre_merge. No function signatures or public interfaces are modified.

Changes

Cohort / File(s) Summary of Changes
Jenkins CI config
jenkins/L0_Test.groovy
In launchTestJobs, removed pre-merge entries B200_PCIe-TensorRT-1 and -2; added B200_PCIe-TensorRT-Post-Merge-1 and -2 with unchanged configurations (["b100-ts2", "l0_b200", 1, 2] and ["b100-ts2", "l0_b200", 2, 2]).
Integration test lists
tests/integration/test_lists/test-db/l0_b200.yml
Changed the TensorRT test block terms.stage from pre_merge to post_merge. PyTorch block remains pre_merge. No tests added/removed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant PR as PR Pipeline (pre-merge)
  participant PM as Post-Merge Pipeline
  participant T as Test Runner
  participant DB as Test List (l0_b200.yml)

  Dev->>PR: Open PR
  PR->>DB: Query tests with stage=pre_merge
  DB-->>PR: PyTorch (B200) only
  PR->>T: Run pre-merge tests
  Note over PR,T: TensorRT (B200) not included pre-merge

  Dev->>PM: Merge to main
  PM->>DB: Query tests with stage=post_merge
  DB-->>PM: TensorRT (B200) tests
  PM->>T: Run post-merge TensorRT tests
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • kxdc
  • yuanjingx87
  • litaotju
  • chzblych

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b8b2bd4 and 67e284a.

📒 Files selected for processing (2)
  • jenkins/L0_Test.groovy (1 hunks)
  • tests/integration/test_lists/test-db/l0_b200.yml (1 hunks)
🔇 Additional comments (2)
tests/integration/test_lists/test-db/l0_b200.yml (1)

82-84: No remaining pre_merge TensorRT in l0_b200.yml; change is correct

Verified with ripgrep that tests/integration/test_lists/test-db/l0_b200.yml contains no stage: pre_merge blocks paired with backend: tensorrt, and all TensorRT tests are now gated under post_merge only.

jenkins/L0_Test.groovy (1)

1837-1838: Verified: B200 TensorRT post-merge stages correctly configured

All checks passed:

  • No pre-merge B200_PCIe-TensorRT-<N> keys remain in jenkins/L0_Test.groovy (ripgrep returned only the Post-Merge variants).
  • In getMakoArgsFromStageName (lines 993–1003), any stageName containing "Post-Merge" gets stage=post_merge, and any containing "-TensorRT-" gets backend=tensorrt.

LGTM.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@QiJune
Copy link
Collaborator Author

QiJune commented Aug 22, 2025

/bot skip --comment "trivial changes"

@QiJune QiJune enabled auto-merge (squash) August 22, 2025 10:04
@tensorrt-cicd
Copy link
Collaborator

PR_Github #16175 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #16175 [ skip ] completed with state SUCCESS
Skipping testing for commit 67e284a

@QiJune QiJune merged commit 1388e84 into NVIDIA:main Aug 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants