[None][fix] Fix a typo in the Slurm CI codes (#7485) #7538
Conversation
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
|
/bot skip --comment "Safe cherry-pick" |
📝 WalkthroughWalkthroughAdds retry-wrapped execution for a Jenkins Docker build step and updates L0 test logic: standardized Slurm logs/timing, dynamic GPU argument resolution for Docker (NV_GPU/CUDA_VISIBLE_DEVICES/gpuCount), cap-add flag format, and inclusion of pipefail in generated multi-node Slurm launch scripts. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant J as Jenkins Pipeline
participant R as Retry Wrapper (llmExecStepWithRetry)
participant SH as Shell
J->>R: Execute NSPECT command (script: cmd, retries=3, timeout=7200s)
loop up to 3 attempts
R->>SH: sh(cmd) with timeout
alt success
SH-->>R: exit 0
R-->>J: success
else failure/timeout
SH-->>R: non-zero/timeout
R-->>R: retry if attempts left
end
end
sequenceDiagram
autonumber
participant J as Jenkins L0
participant C as Config/Env
participant D as Docker
participant S as Slurm (srun/sbatch)
participant F as Launch Script
J->>C: Resolve GPU devices
alt NV_GPU set
C-->>J: --gpus device=$NV_GPU
else CUDA_VISIBLE_DEVICES set
C-->>J: --gpus device=$CUDA_VISIBLE_DEVICES
else
C-->>J: --gpus all/count (from gpuCount)
end
J->>F: Generate multi-node script (set -o pipefail)
J->>S: Submit job with script
Note over S,F: Multi-node test execution
J-->>S: Cleanup sequence
J->>J: Sleep 30s (post-ID, post-checks)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jenkins/L0_Test.groovy (1)
372-384: Fix quoting for--gpus device=…(risk of malformed args).The current echoes produce backslash-escaped quotes (e.g.,
--gpus \"device=0,1\"). Docker doesn’t require quoting here; passing quotes/backslashes through Jenkins’ docker-step can yield invalid CLI args and break GPU selection. Emit plaindevice=values.- dockerGPUOption = sh(script: """ - if [ -n "\$NV_GPU" ]; then - echo "--gpus '\\"device=\$NV_GPU\\"'" - elif [ -n "\$CUDA_VISIBLE_DEVICES" ]; then - echo "--gpus '\\"device=\$CUDA_VISIBLE_DEVICES\\"'" - else - echo "--gpus ${gpuCount}" - fi - """, returnStdout: true).trim() + dockerGPUOption = sh(script: """ + if [ -n "\$NV_GPU" ]; then + echo "--gpus device=\$NV_GPU" + elif [ -n "\$CUDA_VISIBLE_DEVICES" ]; then + echo "--gpus device=\$CUDA_VISIBLE_DEVICES" + else + echo "--gpus ${gpuCount}" + fi + """, returnStdout: true).trim()
🧹 Nitpick comments (4)
jenkins/L0_Test.groovy (4)
166-166: Prefer state-based wait over fixed sleep (multi-node cleanup).Replace the fixed 30s sleep with a short poll that exits as soon as the job leaves the queue.
- Utils.exec(pipeline, script: "echo Sleeping to allow Slurm job completion; sleep 30") + Utils.exec( + pipeline, + script: Utils.sshUserCmd( + remote, + "\"echo Waiting for Slurm job ${slurmJobID} to exit queue; " + + "timeout 180 bash -c 'while squeue -h -j ${slurmJobID} >/dev/null 2>&1; do sleep 2; done' || true\"" + ) + )
176-177: Replace trailing fixed sleep with queue poll (multi-node cleanup).Let’s wait only as long as needed for Slurm to drop the job.
- Utils.exec(pipeline, script: "echo Sleeping to allow Slurm job termination; sleep 30") + Utils.exec( + pipeline, + script: Utils.sshUserCmd( + remote, + "\"timeout 180 bash -c 'while squeue -h -j ${slurmJobID} >/dev/null 2>&1; do sleep 2; done' || true\"" + ) + )
227-228: Replace fixed sleep with queue poll (single-node cleanup).Same optimization for the single-node path.
- Utils.exec(pipeline, script: "echo Sleeping to allow Slurm job termination; sleep 30") + Utils.exec( + pipeline, + script: Utils.sshUserCmd( + remote, + "\"timeout 180 bash -c 'while squeue -h -j ${slurmJobID} >/dev/null 2>&1; do sleep 2; done' || true\"" + ) + )
525-527: Strengthen launch script error handling.Consider failing fast on any pre-srun error by adding
-e(and optionally-u) along withpipefail.- set -o pipefail + set -euo pipefail
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
jenkins/BuildDockerImage.groovy(1 hunks)jenkins/L0_Test.groovy(7 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Filenames compiled into a target must be case-insensitively unique
Files:
jenkins/BuildDockerImage.groovyjenkins/L0_Test.groovy
🧠 Learnings (1)
📚 Learning: 2025-08-22T19:08:10.822Z
Learnt from: yuanjingx87
PR: NVIDIA/TensorRT-LLM#7176
File: jenkins/L0_Test.groovy:361-389
Timestamp: 2025-08-22T19:08:10.822Z
Learning: In Slurm job monitoring scripts, when jobs have built-in timeouts configured (via --time parameter or partition/system timeouts), an additional timeout mechanism in the monitoring loop is typically unnecessary. When a Slurm job times out, it gets terminated and removed from the active queue, causing `squeue -j $jobId` to return non-zero and break monitoring loops naturally. The job's final status can then be checked via `sacct` to determine if it failed due to timeout.
Applied to files:
jenkins/L0_Test.groovy
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (4)
jenkins/BuildDockerImage.groovy (2)
687-687: Wrap with retry looks good.The NSPECT submission is now resilient to transient failures via
llmExecStepWithRetry. No functional concerns.
687-687: ConfirmllmExecStepWithRetrynamed args.Please verify the parameter name is exactly
shortCommondRunTimeMaxin the shared lib; the spelling looks off and might be ignored if mismatched.jenkins/L0_Test.groovy (2)
394-394: Verify--cap-add=SYSLOGsupport.
SYSLOGisn’t universally available on all hosts/runtimes. Confirm Docker on your agents supportsCAP_SYSLOG, or gate this flag behind a feature switch to avoid “invalid capability” errors.
355-355: No stale references after rename Search fordockerGpuOptionreturned no matches; no lingering references remain.
|
PR_Github #17684 [ skip ] triggered by Bot |
|
PR_Github #17684 [ skip ] completed with state |
2 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.