[None][test] Update get_sysinfo.py to avoid UnboundLocalError #7982

yufeiwu-nv · 2025-09-25T07:07:25Z

Description

Move the usage of chip to avoid unboundLocalError
Also, remove unused lower() and upper()

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Bug Fixes
- System Info now displays consistent hardware names. When a PCI device maps to a chip, the board name shows as " Bring-up Board" with the chip in uppercase.
- GPU names preserve their original case and drop the "NVIDIA" prefix for cleaner, more readable labels, avoiding unintended all-caps outputs.

coderabbitai · 2025-09-25T07:12:35Z

📝 Walkthrough

Walkthrough

Updates GPU property construction: casing logic changed for chip and GPU names, and the full_name assignment is moved inside the branch where a PCI device maps to a chip. No changes to error handling or public interfaces.

Changes

Cohort / File(s)	Summary
Sysinfo GPU naming `tests/integration/defs/sysinfo/get_sysinfo.py`	- Use original chip case; set full_name as f"{chip.upper()} Bring-up Board" within the chip-mapped branch - Derive gpu_name by removing "NVIDIA" and trimming without uppercasing - Move full_name assembly into the mapping-yes branch; remove unconditional assignment

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant SysInfo as get_sysinfo.construct_gpu_properties

  Caller->>SysInfo: construct_gpu_properties(pci_device)
  alt PCI maps to chip
    SysInfo->>SysInfo: chip = map_pci_to_chip(pci_device)
    Note right of SysInfo: Use chip original case
    SysInfo->>SysInfo: full_name = chip.toUpperCase() + " Bring-up Board"
    SysInfo->>SysInfo: gpu_name = remove "NVIDIA" from raw name, trim (no uppercasing)
  else No mapping
    SysInfo->>SysInfo: gpu_name = remove "NVIDIA" from raw name, trim
    Note right of SysInfo: No full_name assignment here
  end
  SysInfo-->>Caller: GPU properties

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The description includes the required sections but leaves the Test Coverage section empty, providing no details on which tests cover the new logic and missing any information on relevant test cases for the changes in get_sysinfo.py.	Please populate the Test Coverage section with specific test names or descriptions that validate the new control flow and casing logic in get_sysinfo.py to ensure adequate coverage of the updated behavior.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title follows the repository’s ticket-type format and clearly summarizes the primary change of updating get_sysinfo.py to prevent an UnboundLocalError, making it concise and relevant to the modifications in this PR.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 259cc66 and ce942f5.

📒 Files selected for processing (1)

tests/integration/defs/sysinfo/get_sysinfo.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

tests/integration/defs/sysinfo/get_sysinfo.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

tests/integration/defs/sysinfo/get_sysinfo.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

tests/integration/defs/sysinfo/get_sysinfo.py

🧬 Code graph analysis (1)

tests/integration/defs/sysinfo/get_sysinfo.py (1)

tensorrt_llm/logger.py (1)

warning (132-133)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

StanleySun639 · 2025-09-25T08:01:26Z

/bot run

tensorrt-cicd · 2025-09-25T08:13:39Z

PR_Github #19917 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-25T08:40:54Z

PR_Github #19917 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #14993 completed with status: 'FAILURE'

yufeiwu-nv · 2025-09-25T09:16:04Z

/bot run

tensorrt-cicd · 2025-09-25T09:21:14Z

PR_Github #19927 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-25T12:50:26Z

PR_Github #19927 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15001 completed with status: 'FAILURE'

yufeiwu-nv · 2025-09-26T06:59:10Z

/bot run --reuse-test

tensorrt-cicd · 2025-09-26T07:04:34Z

PR_Github #20058 [ run ] triggered by Bot

yufeiwu-nv · 2025-09-26T09:22:45Z

/bot run

tensorrt-cicd · 2025-09-26T09:28:03Z

PR_Github #20078 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-26T09:28:05Z

PR_Github #20058 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15111 (Blue Ocean) completed with status: ABORTED

tensorrt-cicd · 2025-09-26T13:18:50Z

PR_Github #20078 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15126 completed with status: 'SUCCESS'

tests/integration/defs/sysinfo/get_sysinfo.py

StanleySun639 · 2025-09-29T06:05:12Z

/bot run --skip-test

tensorrt-cicd · 2025-09-29T06:10:15Z

PR_Github #20224 [ run ] triggered by Bot

tensorrt-cicd · 2025-09-29T08:31:43Z

PR_Github #20224 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15254 (Partly Tested) completed with status: 'SUCCESS'

… and validation without docker(baremetal) Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>

Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

StanleySun639 · 2025-09-29T08:54:40Z

/bot reuse-pipeline

tensorrt-cicd · 2025-09-29T08:59:56Z

PR_Github #20253 [ reuse-pipeline ] triggered by Bot

tensorrt-cicd · 2025-09-29T09:14:37Z

PR_Github #20253 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20224 (Partly Tested) for commit f6ab38e

yufeiwu-nv marked this pull request as draft September 25, 2025 07:09

yufeiwu-nv force-pushed the yufeiwu-nv-patch-1 branch from ead2f50 to 18be8f4 Compare September 25, 2025 07:23

yufeiwu-nv requested review from LarryXFly, StanleySun639 and ruodil September 25, 2025 07:53

yufeiwu-nv marked this pull request as ready for review September 25, 2025 07:54

yufeiwu-nv changed the title ~~[None][Test]Update get_sysinfo.py to avoid UnboundLocalError~~ [None][test] Update get_sysinfo.py to avoid UnboundLocalError Sep 25, 2025

StanleySun639 force-pushed the yufeiwu-nv-patch-1 branch from ce942f5 to dba96b4 Compare September 25, 2025 08:01

yufeiwu-nv enabled auto-merge (squash) September 26, 2025 06:53

StanleySun639 reviewed Sep 29, 2025

View reviewed changes

tests/integration/defs/sysinfo/get_sysinfo.py Outdated Show resolved Hide resolved

StanleySun639 approved these changes Sep 29, 2025

View reviewed changes

LarryXFly approved these changes Sep 29, 2025

View reviewed changes

yufeiwu-nv added 2 commits September 29, 2025 16:53

[None][test] Update llm_models_root function to improve path handling…

defa196

… and validation without docker(baremetal) Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

Update get_sysinfo.py to avoid UnboundLocalError

e5b0bb2

Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>

yufeiwu-nv added 4 commits September 29, 2025 16:53

fix submodule issue

76b776c

Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

fix pre-commit

692d50f

Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

Upcase full_name and gpu_name

f917f8a

Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

Add corner-case when not using chip name as full_name

f6ab38e

Signed-off-by: yufeiwu <230315618+yufeiwu-nv@users.noreply.github.com>

StanleySun639 force-pushed the yufeiwu-nv-patch-1 branch from 736e10e to f6ab38e Compare September 29, 2025 08:53

yufeiwu-nv merged commit 3ba6727 into NVIDIA:main Sep 29, 2025
5 checks passed

yufeiwu-nv deleted the yufeiwu-nv-patch-1 branch October 9, 2025 05:50

[None][test] Update get_sysinfo.py to avoid UnboundLocalError #7982

[None][test] Update get_sysinfo.py to avoid UnboundLocalError #7982

Uh oh!

Conversation

yufeiwu-nv commented Sep 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

StanleySun639 commented Sep 25, 2025

Uh oh!

tensorrt-cicd commented Sep 25, 2025

Uh oh!

tensorrt-cicd commented Sep 25, 2025

Uh oh!

yufeiwu-nv commented Sep 25, 2025

Uh oh!

tensorrt-cicd commented Sep 25, 2025

Uh oh!

tensorrt-cicd commented Sep 25, 2025

Uh oh!

yufeiwu-nv commented Sep 26, 2025

Uh oh!

tensorrt-cicd commented Sep 26, 2025

Uh oh!

yufeiwu-nv commented Sep 26, 2025

Uh oh!

tensorrt-cicd commented Sep 26, 2025

Uh oh!

tensorrt-cicd commented Sep 26, 2025

Uh oh!

tensorrt-cicd commented Sep 26, 2025

Uh oh!

Uh oh!

StanleySun639 commented Sep 29, 2025

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

StanleySun639 commented Sep 29, 2025

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

tensorrt-cicd commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yufeiwu-nv commented Sep 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 25, 2025 •

edited

Loading