Walkthrough

Implements MTP Eagle mode handling across speculative decoding: guarded Eagle3 resource manager initialization, dedicated metadata path for MTP Eagle, and an overlap-scheduler disablement for MTP_EAGLE. Adds a test entry for MTP Eagle. No public exports removed; Eagle3SpecMetadata gains an is_mtp_eagle parameter.

Changes

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant SpecMode as SpeculativeDecodingMode
  participant Utils as get_spec_metadata
  participant RM as Eagle3ResourceManager

  Caller->>SpecMode: support_overlap_scheduler()
  alt mode == MTP_EAGLE
    SpecMode-->>Caller: False (early return)
  else other modes
    SpecMode-->>Caller: fallback logic
  end

  Caller->>Utils: get_spec_metadata(spec_dec_mode, config, model)
  alt spec_dec_mode.is_mtp_eagle
    Utils->>RM: init(config)
    note right of RM: If config is EagleDecodingConfig:<br/>- set max_total_draft_tokens from config<br/>- create spec_tree_manager when eagle_choices present
    RM-->>Utils: resource manager
    Utils-->>Caller: Eagle3SpecMetadata(..., is_mtp_eagle=True)
  else spec_dec_mode.is_eagle3
    Utils-->>Caller: Eagle3SpecMetadata(..., is_mtp_eagle=False)
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• 📝 Generate Docstrings

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

• X
• Mastodon
• Reddit
• LinkedIn

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.