KEMBAR78
[https://nvbugs/5547416][fix] unwaive no_cache test by byshiue · Pull Request #8213 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@byshiue
Copy link
Collaborator

@byshiue byshiue commented Oct 9, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped integration test covering bf16 mixed-precision on multi-GPU setups, restoring validation for this configuration.
    • Enhances test coverage and CI reliability, increasing confidence in distributed and performance-sensitive scenarios.
    • No changes to product behavior or user workflows; impact is limited to quality assurance and earlier detection of regressions.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
@byshiue
Copy link
Collaborator Author

byshiue commented Oct 9, 2025

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-7" --only-multi-gpu-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

📝 Walkthrough

Walkthrough

Removed a Skip marker from the waives list to enable running the test accuracy/test_llm_api_pytorch.py::TestQwen3_8B::test_bf16[multi_gpus_no_cache]. No other changes.

Changes

Cohort / File(s) Change Summary
Test waives update
tests/integration/test_lists/waives.txt
Removed Skip marker entry for TestQwen3_8B BF16 multi-GPU no-cache test, allowing it to run

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description contains only the template placeholders without any actual content in the Description or Test Coverage sections, so it fails to explain the rationale for the change or list the relevant tests that are now enabled. Please replace the template placeholders with a concise explanation of why the skip marker was removed and how the change affects testing, and complete the Test Coverage section by listing the specific test that is now enabled; ensure the PR Checklist is appropriately reviewed afterward.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title correctly follows the repository’s naming convention by including the NVBugs ID and “[fix]” type, and it succinctly summarizes the core change of unwaiving the no_cache test, which directly matches the removal of the skip marker in the test suite.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27677a3 and cde6a48.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20856 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20856 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15773 (Partly Tested) completed with status: 'SUCCESS'

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 9, 2025

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20875 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20875 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15790 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 9, 2025

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-9" --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20897 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20897 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15809 (Partly Tested) completed with status: 'SUCCESS'

@byshiue
Copy link
Collaborator Author

byshiue commented Oct 10, 2025

/bot skip --comment "the unwaived CI has passed"

@byshiue byshiue enabled auto-merge (squash) October 10, 2025 08:32
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21009 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21009 [ skip ] completed with state SUCCESS
Skipping testing for commit cde6a48

@byshiue byshiue merged commit d3059db into NVIDIA:main Oct 10, 2025
8 of 9 checks passed
@byshiue byshiue deleted the nvbug_5547416 branch October 15, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants