KEMBAR78
[None][fix] Add failed cases into waives.txt by xinhe-nv · Pull Request #8229 · NVIDIA/TensorRT-LLM · GitHub
Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Oct 9, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Expanded the waiver list to include two additional end-to-end tests marked as skipped, with associated issue references.
    • These tests will now be reported as skipped during automated runs across environments.
    • No changes to application behavior, features, or performance; only test execution and reporting are affected.

@xinhe-nv xinhe-nv marked this pull request as ready for review October 10, 2025 01:50
@xinhe-nv
Copy link
Collaborator Author

/bot run

@xinhe-nv
Copy link
Collaborator Author

/bot --skip-test

@github-actions
Copy link

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

Added two SKIP waivers to tests/integration/test_lists/waives.txt for test_e2e.py::test_openai_chat_harmony and test_e2e.py::test_ptp_quickstart_multimodal[...] with associated SKIP annotations and nvbugs IDs. No other files or code paths modified.

Changes

Cohort / File(s) Summary
Test waivers update
tests/integration/test_lists/waives.txt
Appended two SKIP entries for specific e2e tests, including annotations and nvbugs IDs; no other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The provided description consists of a single brief phrase and does not follow the repository’s template, which requires sections for summary, detailed description, test coverage, and a PR checklist. Please update the pull request description to include the structured template sections: a concise summary of changes, an explanation of the issue and solution, details on relevant test coverage, and the completed PR checklist as specified in the repository’s description template.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title succinctly describes the primary change of adding failed test cases into the waives.txt file and directly reflects the contents of the changeset without extraneous detail.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251009_LLM_FUNCTION_TEST_1466 branch 2 times, most recently from 6dd4508 to e966b4c Compare October 10, 2025 01:57
@xinhe-nv
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20944 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251009_LLM_FUNCTION_TEST_1466 branch from e966b4c to c194026 Compare October 10, 2025 02:57
@xinhe-nv xinhe-nv enabled auto-merge (squash) October 10, 2025 02:58
@xinhe-nv xinhe-nv changed the title [None][chore] Add failed cases into waives.txt [None][fix] Add failed cases into waives.txt Oct 10, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20944 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15844 (Partly Tested) completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv requested a review from crazydemo October 10, 2025 05:35
@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20970 [ reuse-pipeline ] triggered by Bot

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251009_LLM_FUNCTION_TEST_1466 branch from c9f13a7 to 28ed202 Compare October 10, 2025 06:00
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20970 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20944 (Partly Tested) for commit c9f13a7

@xinhe-nv
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20981 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20981 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #20944 (Partly Tested) for commit 28ed202

@xinhe-nv xinhe-nv merged commit b555f1f into NVIDIA:main Oct 10, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251009_LLM_FUNCTION_TEST_1466 branch October 10, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants