Fix synthesis of vectors with small integers. #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant array op is using at ArrayAttr, which does not naturally support integral sizes less than i32. This patch upcasts the short values to i32 to get around the issue. Another approach would be to have the constant array op take a DenseArrayAttr, which does support the shorter integral types. Might need a custom parser/pretty printer if we go that route?
schweitzpgi
changed the title
Command Bot: Processing... |
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant array op is using at ArrayAttr, which does not naturally support integral sizes less than i32. This patch upcasts the short values to i32 to get around the issue. Another approach would be to have the constant array op take a DenseArrayAttr, which does support the shorter integral types. Might need a custom parser/pretty printer if we go that route?
Fix #1384