Bug fixes for multi-GPU statevector simulator #2313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Fixed integer overflow when converting CUDAQ_MAX_GPU_MEMORY_GB to bytes. - Fixed issues with large CUDAQ_MAX_CPU_MEMORY_GB setting: always cap it based on actual memory availability. - Fixed an issue with setting validation: some settings that allow zero was wrongly rejected. Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
1tnguyen
requested review from
amccaskey,
bettinaheim and
bmhowe23
as code owners
bmhowe23
approved these changes
Oct 23, 2024
bettinaheim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
Fixed integer overflow when converting
CUDAQ_MAX_GPU_MEMORY_GBto bytes.Fixed issues with large
CUDAQ_MAX_CPU_MEMORY_GBsetting: always cap it based on actual memory availability.Fixed an issue with setting validation: some settings that allow zero was wrongly rejected.
See cuquantum-mgpu MR!30