KEMBAR78
Fix incorrect call return for python device kernels by annagrin · Pull Request #2319 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@annagrin
Copy link
Collaborator

@annagrin annagrin commented Oct 25, 2024

Detect correct return type of the callees in python when generating return statements in ast_bridge.py

Closes: #2250

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: ce0fd32

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks, Anna!
One clarifying Q and one nit.

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
@annagrin annagrin enabled auto-merge (squash) November 1, 2024 23:29
@amccaskey
Copy link
Collaborator

amccaskey commented Nov 2, 2024

/ok to test

Command Bot: Processing...

@annagrin annagrin merged commit 2c162ab into NVIDIA:main Nov 3, 2024
208 checks passed
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] Returning from non-top kernels fails during compilation

4 participants