KEMBAR78
OQC client upgrade by jfriel-oqc · Pull Request #2352 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@jfriel-oqc
Copy link
Contributor

Code changes for the latest version of the OQC client to stay aligned with API changes.

Tests updated and tested locally.

Following with doc changes, just getting the code up now.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 4, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 4, 2024

/ok to test

Command Bot: Processing...

jamie added 2 commits November 7, 2024 22:07
I, jamie <jfriel@oxfordquantumcircuits.com>, hereby add my Signed-off-by to this commit: 7d7c716

Signed-off-by: jamie <jfriel@oxfordquantumcircuits.com>
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 12, 2024

/ok to test

Command Bot: Processing...

Signed-off-by: Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>

DCO Remediation Commit for Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>

I, Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>, hereby add my Signed-off-by to this commit: d019f7e
I, Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>, hereby add my Signed-off-by to this commit: f26f908
I, Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>, hereby add my Signed-off-by to this commit: 88734a5

Signed-off-by: Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>

DCO Remediation Commit for root <nkushida@oxfordquantumcircuits.com>

I, root <nkushida@oxfordquantumcircuits.com>, hereby add my Signed-off-by to this commit: b453c84

Signed-off-by: root <nkushida@oxfordquantumcircuits.com>
I, root <nkushida@oxfordquantumcircuits.com>, hereby add my Signed-off-by to this commit: b453c84

Signed-off-by: root <nkushida@oxfordquantumcircuits.com>

Signed-off-by: root <nkushida@oxfordquantumcircuits.com>
Signed-off-by: Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 13, 2024

/ok to test

Command Bot: Processing...

Signed-off-by: Noriyuki Kushida <nkushida@oxfordquantumcircuits.com>
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 13, 2024

/ok to test

Command Bot: Processing...

Signed-off-by: root <nkushida@oxfordquantumcircuits.com>
@bettinaheim
Copy link
Collaborator

bettinaheim commented Nov 14, 2024

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 14, 2024

/ok to test

Command Bot: Processing...

Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes LGTM. Thank you, @jfriel-oqc and @nkushida-oqc!

@bmhowe23 bmhowe23 enabled auto-merge (squash) November 15, 2024 00:37
@bmhowe23 bmhowe23 merged commit 3300b12 into NVIDIA:main Nov 15, 2024
219 of 223 checks passed
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants