Python metapackages #2356
Merged
Python metapackages #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2356 +/- ##
=======================================
Coverage ? 78.66%
=======================================
Files ? 338
Lines ? 45693
Branches ? 0
=======================================
Hits ? 35943
Misses ? 9750
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
…blishing Signed-off-by: Bettina Heim <heimb@outlook.com>
bettinaheim
commented
Nov 6, 2024
Signed-off-by: Bettina Heim <heimb@outlook.com>
sacpis
reviewed
Nov 6, 2024
sacpis
reviewed
Nov 6, 2024
sacpis
reviewed
Nov 6, 2024
sacpis
reviewed
Nov 6, 2024
sacpis
reviewed
Nov 6, 2024
Signed-off-by: Bettina Heim <heimb@outlook.com>
sacpis
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Have few questions, but overall this PR looks good to me. Thanks @bettinaheim.
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
GitHub Actions
Inactive
Signed-off-by: Bettina Heim <heimb@outlook.com>
bettinaheim
added
the
release notes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
cudaqpython package. Upon installation, the package will look for the CUDA version installed on the system, and download the correct CUDA-Q binary distribution for that version.Note that different version of the CUDA-Q binary distribution (e.g. the cuda 11 and the cuda 12 version) will conflict with each other. It would be nice for the
cudaqpackage to detect conflicting installations and give an error. Right now that is not yet set up. The requirement to uninstall the conflicting packages prior to installingcudaqis documented.