Switch the default to enable mlir #2366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
force-pushed
the
ch-enable.mlir.default.3
branch
from
048c0f8 to
fec3cc6
Compare
Update the tests and the driver to make --enable-mlir the default. Add a new option, --library-mode, to allow the user to select the old default of library mode. Add required command line argument to tests. Repair the function definition as well. The option is always ignored. Hardcode library-mode into the add_nvqpp_test function instead. Fix validation script to respect the compiler mode selected. Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
force-pushed
the
ch-enable.mlir.default.3
branch
from
fec3cc6 to
bdad400
Compare
bettinaheim
changed the title
bettinaheim
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tests and the driver to make --enable-mlir the default. Add a new option, --library-mode, to allow the user to select the old default of library mode.