KEMBAR78

Support measurement sampling seed for `cutensornet` backends by 1tnguyen · Pull Request #2398 · NVIDIA/cuda-quantum · GitHub

Support measurement sampling seed for `cutensornet` backends #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

1tnguyen merged 8 commits into NVIDIA:main from 1tnguyen:tnguyen/cutensornet-sampling-seed

Nov 27, 2024

Collaborator

1tnguyen commented Nov 20, 2024

Description

This support has been added in cutensornet v2.5.
Majority of the code change is to propagate the Simulator-level random engine to all the State classes. These are references to the single instance at the backend level, which is seeded by the cudaq runtime.
Re-enable the test that was skipped due to the lack of this support.

Fixed #895

Test results of the re-enabled tests:

   Start 461: tensornet_GHZSampleTester.checkBroadcastRepeatability
5/7 Test #461: tensornet_GHZSampleTester.checkBroadcastRepeatability .........   Passed    1.57 sec
    Start 559: tensornet_mps_GHZSampleTester.checkBroadcastRepeatability
6/7 Test #559: tensornet_mps_GHZSampleTester.checkBroadcastRepeatability .....   Passed    2.04 sec

1tnguyen added 2 commits

November 20, 2024 05:26


          Support measurement sampling seed for cutensornet backends

403b656

This feature has been added in 24.08 (cutensornet 2.5), hence adding the
support for it and re-enable the skipped test.

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>


          Fix a code comment

325f9aa

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

1tnguyen requested review from sacpis and schweitzpgi

November 20, 2024 05:39

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/mps_simulation_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/mps_simulation_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/mps_simulation_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/mps_simulation_state.h Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/simulator_cutensornet.h Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.cpp Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.h Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.h Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.h Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.h Outdated Show resolved Hide resolved

sacpis reviewed

View reviewed changes

runtime/nvqir/cutensornet/tensornet_state.h Outdated Show resolved Hide resolved

sacpis approved these changes

View reviewed changes

Collaborator

sacpis left a comment

Approved with minor changes. Thanks @1tnguyen.


          Code review: edit variable names and code comments

c6c2fdb

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>

1tnguyen requested a review from sacpis

November 20, 2024 22:35

sacpis approved these changes

View reviewed changes

Collaborator

sacpis left a comment

LGTM. Thanks @1tnguyen.


          Code format

4944cb5

Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>


          Merge branch 'main' into tnguyen/cutensornet-sampling-seed

1e8fa41

schweitzpgi approved these changes

View reviewed changes

1tnguyen added 3 commits

November 26, 2024 06:06


          Merge branch 'main' into tnguyen/cutensornet-sampling-seed

50b607e


          Merge branch 'main' into tnguyen/cutensornet-sampling-seed

712641e


          Merge branch 'main' into tnguyen/cutensornet-sampling-seed

b4df839

1tnguyen merged commit d133531 into NVIDIA:main

211 of 212 checks passed

1tnguyen mentioned this pull request

Make controlled rank a configurable setting for tensornet backends #2446

Merged

bettinaheim added the release notes label

bettinaheim added this to the release 0.9.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels