Support measurements of subveqs for braket #2416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…aket-pipeline Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…aket-pipeline Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
* Two more tests working Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
* Additional tests Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
* Test for asynchronous sampling API * Failing test for observe API * More tests to cover all native gates, custom operations * One more test - check kernel that takes arguments Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
not supported. * Simplify test setup since mock server isn't being used. Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Co-authored-by: Bettina Heim <heimb@outlook.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
* Two more tests working Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
* Additional tests Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
* Test for asynchronous sampling API * Failing test for observe API * More tests to cover all native gates, custom operations * One more test - check kernel that takes arguments Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
not supported. * Simplify test setup since mock server isn't being used. Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Co-authored-by: Bettina Heim <heimb@outlook.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
boschmitt
reviewed
Nov 26, 2024
runtime/cudaq/platform/default/rest/helpers/braket/BraketExecutor.cpp
Outdated
Show resolved
Hide resolved
bmhowe23
reviewed
Nov 26, 2024
runtime/cudaq/platform/default/rest/helpers/braket/BraketExecutor.cpp
Outdated
Show resolved
Hide resolved
bmhowe23
reviewed
Nov 26, 2024
runtime/cudaq/platform/default/rest/helpers/braket/BraketServerHelper.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…aket-pipeline-3 Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
bmhowe23
reviewed
Nov 27, 2024
runtime/cudaq/platform/default/rest/helpers/braket/BraketServerHelper.cpp
Outdated
Show resolved
Hide resolved
bmhowe23
reviewed
Nov 27, 2024
runtime/cudaq/platform/default/rest/helpers/braket/BraketServerHelper.cpp
Show resolved
Hide resolved
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
4 tasks
bmhowe23
reviewed
Nov 27, 2024
I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: 3966ee3 Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…aket-pipeline-3 Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
khalatepradnya
changed the title
bettinaheim
added
the
release notes
schweitzpgi
reviewed
Dec 11, 2024
| Pass<"combine-measurements", "mlir::func::FuncOp"> { | ||
| let summary = "Extends mesurements on subveqs adds output names"; | ||
| let description = [{ | ||
| Replace a pattern such as: |
There was a problem hiding this comment.
We need to add documentation here that this transformation changes the semantics of the program. Running this pass produces a program that is not what the user wrote, so it is imperative that some sort of cleanup will be done to functionally cancel this transformation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support measurements of subveqs for braket
CombineMeasurementspasssubveqto the full vector and addoutput_namesattributestranslateToOpenQasmpipeline that would be normally specified in target config files.