KEMBAR78
Support for allocatable quantum structs by schweitzpgi · Pull Request #2432 · NVIDIA/cuda-quantum · GitHub
Skip to content

Conversation

@schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Nov 27, 2024

This allows the basic support for a struct of quantum vectors or singletons. Previously quantum structs were limited strictly to references, but these changes allow qubits to be allocated implicitly.

Remove test as no longer relevant. Add new test to cover cases.

@schweitzpgi schweitzpgi enabled auto-merge (squash) November 27, 2024 22:16
@schweitzpgi schweitzpgi requested a review from bmhowe23 November 27, 2024 22:32
This allows the basic support for a struct of quantum vectors or
singletons. Previously quantum structs were limited strictly to
references, but these changes allow qubits to be allocated implicitly.

Remove test as no longer relevant. Add new test to cover cases.

Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Signed-off-by: Eric Schweitz <eschweitz@nvidia.com>
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@schweitzpgi schweitzpgi merged commit 0edc3c1 into NVIDIA:main Nov 28, 2024
213 checks passed
@schweitzpgi schweitzpgi deleted the ch-struq.allocation branch December 9, 2024 16:24
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Dec 10, 2024
@bettinaheim bettinaheim added this to the release 0.9.1 milestone Dec 10, 2024
@bettinaheim bettinaheim changed the title [core] Support for allocatable quantum structs Support for allocatable quantum structs Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants