Fix incorrect handling of measurements in value semantics representation #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measurements now thread the wires as well as the bool result value in the value semantics. Each wire needs to be forwarded correctly.
bmhowe23
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
LGTM. We've discussed offline that we expect the mapping changes to exercise and test this new code. I'm just reiterating that here in the review so that we have a record of it (as a partial explanation for why there's not currently any new tests for this PR).
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measurements now thread the wires as well as the bool result value in the value semantics. Each wire needs to be forwarded correctly.