KEMBAR78
Fix for misleading CUDA not found message by khalatepradnya · Pull Request #986 · NVIDIA/cuda-quantum · GitHub
Skip to content

Fix for misleading CUDA not found message #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix for misleading CUDA not found message #986

merged 1 commit into from
Nov 30, 2023

Conversation

@khalatepradnya
Copy link
Collaborator

  • Some Python backend tests fail by reporting custatevec errors when running on a machine with GPUs
    • Set the target in test fixture that starts mock server
    • Wrap the call to cudaGetDevice in CUDA error handler for early catching

Description

Addresses #977

@khalatepradnya
* Fix for Issue#977
ad282ba 
  Some Python backend tests fail by reporting custatevec errors when running on a machine with GPUs

-- Set the target in test fixture that starts mock server
-- Wrap the call to 'cudaGetDevice' in CUDA error handler for early
catching
@khalatepradnya khalatepradnya self-assigned this Nov 30, 2023
bmhowe23
bmhowe23 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 👍

1tnguyen
1tnguyen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khalatepradnya khalatepradnya enabled auto-merge (squash) November 30, 2023 20:59
@khalatepradnya khalatepradnya merged commit daf8d57 into NVIDIA:main Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@khalatepradnya khalatepradnya deleted the fix/issue-977 branch November 30, 2023 23:06
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim changed the title Fix for Issue#977 Fix for misleading CUDA not found message Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees

@khalatepradnya khalatepradnya

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Milestone

release 0.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@khalatepradnya @1tnguyen @bmhowe23 @bettinaheim