KEMBAR78
Fix deprecated implicit copy constructor warnings in __annotated_ptr by wmaxey · Pull Request #255 · NVIDIA/libcudacxx · GitHub
Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Fix deprecated implicit copy constructor warnings in __annotated_ptr #255

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix deprecated implicit copy constructor warnings in __annotated_ptr #255

merged 1 commit into from
Mar 11, 2022

Conversation

@wmaxey
Copy link
Member

@wmaxey wmaxey commented Mar 10, 2022 

include/cuda/std/detail/__annotated_ptr:126:11: error: definition of implicit copy assignment operator for '__annotated_ptr_base<cuda::access_property::shared>' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
constexpr __annotated_ptr_base(const __detail_ap::__annotated_ptr_base< access_property::shared>  &) = default;

Fixes this warning in Clang-13.

@wmaxey wmaxey added the nvbug Has an associated internal NVIDIA NVBug. label Mar 10, 2022
@wmaxey wmaxey requested a review from griwes March 10, 2022 20:41
@wmaxey wmaxey self-assigned this Mar 10, 2022
@wmaxey wmaxey merged commit d1501ba into main Mar 11, 2022
@wmaxey wmaxey deleted the bugfix/ap_deprecated_ctor branch March 11, 2022 21:50
@wmaxey wmaxey added this to the 1.8.0 milestone Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@griwes griwes griwes approved these changes

@davedsth davedsth davedsth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wmaxey wmaxey

Labels

nvbug Has an associated internal NVIDIA NVBug.

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wmaxey @griwes @davedsth