This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix MSVC test failures. #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatic_cast in problematic areas
griwes
suggested changes
Apr 25, 2022
| #include "test_macros.h" | ||
|
|
||
| #if defined(_MSC_VER) | ||
| # pragma warning( disable: 4307 ) |
There was a problem hiding this comment.
Can you add comments to these, similarly how the 4244 disables have comments?
| const unsigned __mp = (5 * __doy + 2)/153; // [0, 11] | ||
| const unsigned __dy = __doy - (153 * __mp + 2)/5 + 1; // [1, 31] | ||
| const unsigned __mth = __mp + (__mp < 10 ? 3 : -9); // [1, 12] | ||
| const unsigned __mth = __mp + static_cast<unsigned>(__mp < 10 ? 3 : -9); // [1, 12] |
There was a problem hiding this comment.
Re-align the trailing comment with the 9nes in the previous lines.
| const unsigned __doy = (153 * (__mth + (__mth > 2 ? -3 : 9)) + 2) / 5 + __dy-1; // [0, 365] | ||
| const unsigned __doe = __yoe * 365 + __yoe/4 - __yoe/100 + __doy; // [0, 146096] | ||
| const unsigned __yoe = static_cast<unsigned>(__yr - __era * 400); // [0, 399] | ||
| const unsigned __doy = static_cast<unsigned>((153 * (__mth + static_cast<unsigned>(__mth > 2 ? -3 : 9)) + 2) / 5 + __dy-1); // [0, 365] |
There was a problem hiding this comment.
Why is the outer static_cast needed here?
There was a problem hiding this comment.
Two problems mainly. __mth + negative signed integer is a warning. The assignment ends up being a demotion as well after xy / 5 + __dy-1
wmaxey
commented
Apr 26, 2022
griwes
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit chain will include fixes to address failures detected across several versions of MSVC. I've used the compilers listed below that I believe are major releases for MSVC.
MSVC versions that are clean: