This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Implement {async_}resource_ref
#309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
commented
Aug 30, 2022
miscco
commented
Aug 30, 2022
miscco
commented
Aug 30, 2022
miscco
commented
Aug 30, 2022
jrhemstad
reviewed
Aug 30, 2022
miscco
commented
Aug 30, 2022
miscco
force-pushed
the
memory_resource
branch
from
f5c6d23 to
a90c51a
Compare
miscco
force-pushed
the
memory_resource
branch
7 times, most recently
from
a76195e to
72bafd0
Compare
miscco
force-pushed
the
memory_resource
branch
from
72bafd0 to
01ca2d8
Compare
|
NOTE to reviewers: I have pushed the concept emulation into its own branch and targeted this PR to that branch. Consequentlly, we can review only the |
miscco
force-pushed
the
memory_resource
branch
from
01ca2d8 to
4bbdd28
Compare
miscco
force-pushed
the
memory_resource
branch
5 times, most recently
from
a3b81f8 to
530c0c2
Compare
mzient
reviewed
Sep 14, 2022
mzient
reviewed
Sep 14, 2022
mzient
reviewed
Sep 14, 2022
mzient
reviewed
Sep 14, 2022
mzient
reviewed
Sep 14, 2022
jrhemstad
reviewed
Dec 1, 2022
.upstream-tests/test/cuda/memory_resource/memory_resource.concepts/has_property.pass.cpp
Outdated
Show resolved
Hide resolved
jrhemstad
reviewed
Dec 2, 2022
miscco
force-pushed
the
memory_resource
branch
from
ee5745f to
0388909
Compare
miscco
force-pushed
the
memory_resource
branch
from
0388909 to
c1e1a52
Compare
This includes: * cuda::mr::has_property * cuda::mr::has_property_with * cuda::mr::resource * cuda::mr::resource_with * cuda::mr::async_resource * cuda::mr::async_resource_with
This includes * `cuda::mr::resource_ref` * `cuda::mr::async_resource_ref`
miscco
force-pushed
the
memory_resource
branch
from
c1e1a52 to
85c8aa5
Compare
miscco
force-pushed
the
memory_resource
branch
from
85c8aa5 to
572f73d
Compare
This was referenced Feb 20, 2023
Closed
griwes
approved these changes
Mar 6, 2023
4 tasks
|
I'm bothered that this was merged without finishing the documentation checkbox. At least a new issue should be opened when that happens. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the NVIDIA internal proposal for a
any_resource_refabstraction that facilitates the handling of memory allocations on host and device side.To facilitate adoption the proposal is backported to C++14 / C++17 through a concept emulation designed by @ericniebler. Unfortunately, C++11 is too far a stretch due to missing support for constexpr variables.
Currently only plain
any_resource_refresource is implemented, asasync_resource_refis more or less a straightforward extension.Things still to do:
async_resource_refequality_comparableconcept