<atomics> Remove defaulted copy constructor from __cxx_atomic_lock_impl #310
Conversation
Defaulting the copy constructor inhibits the compiler defaulting the move constructor. Also it is not needed here at all. Fixes: nvbug3785347
What if we just default the move ctor also? I tend to subscribe to the "Explicit Rule of 0" , but it's not a hill I'd die on. |
|
We should then also default all other special member functions and personally I am not a fan of adding mental load for no benefit. |
|
I agree with removing ctor if it's not necessary. I had added it for some reason... and am currently investigating its requirement. I do have a test fix for MSVC I'll be pushing soon. |
|
My general stance is that there is code and there is fundamental c++ library code. With "normal" application code or even some framework I am all in on being more expressive even if not needed. With a library like the STL it is different, because there are so many nuances and special cases that are actually needed, that adding "unnecessary" code adds a lot of mental overhead. Why is this assignment written differently? Often there is a situation, where doing something slightly different is necessary and I want that to stand out. |
Fixes test failure: ``` 2022-09-13 01:22:39+00:00| 11 | # error "CUDA atomics are only supported for sm_60 and up on *nix and sm_70 and up on Windows." 2022-09-13 01:22:39+00:00| | ^~~~~ 2022-09-13 01:22:39+00:00| # --error 0x1 -- 2022-09-13 01:22:39+00:00| -- 2022-09-13 01:22:39+00:00| 2022-09-13 01:22:39+00:00| Compilation failed unexpectedly! 2022-09-13 01:22:39+00:00| ******************** 2022-09-13 01:25:32+00:00| 2022-09-13 01:25:32+00:00| 6 warning(s) in tests 2022-09-13 01:25:32+00:00| ******************** 2022-09-13 01:25:32+00:00| Failed Tests (1): 2022-09-13 01:25:32+00:00| libcu++ :: std/atomics/atomics.types.generic/non_trivial.pass.cpp 2022-09-13 01:25:32+00:00| 2022-09-13 01:25:32+00:00| 2022-09-13 01:25:32+00:00| Testing Time: 177.83s 2022-09-13 01:25:32+00:00| Unsupported : 215 2022-09-13 01:25:32+00:00| Passed : 1000 2022-09-13 01:25:32+00:00| Expectedly Failed: 17 2022-09-13 01:25:32+00:00| Failed : 1 ```
|
Thanks a lot @wmaxey |
3 participants
Defaulting the copy constructor inhibits the compiler defaulting the move constructor. Also it is not needed here at all.
Fixes: nvbug3785347