This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix structured binding support #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
added
the
testing: internal ci in progress
wmaxey
reviewed
Sep 22, 2022
| template <class _Tp, size_t _Size> | ||
| struct tuple_size<_CUDA_VSTD::array<_Tp, _Size>> | ||
| : _CUDA_VSTD::tuple_size<_CUDA_VSTD::array<_Tp, _Size>> | ||
| {}; |
There was a problem hiding this comment.
libcxx is failing to build due to this:
2022-09-22 06:23:19+00:00| In file included from /sw/gpgpu/libcudacxx/libcxx/src/filesystem/filesystem_common.h:14:
2022-09-22 06:23:19+00:00| /sw/gpgpu/libcudacxx/libcxx/include/array:497:12: error: explicit specialization of non-template struct 'tuple_size'
2022-09-22 06:23:19+00:00| struct tuple_size<_CUDA_VSTD::array<_Tp, _Size>>
2022-09-22 06:23:19+00:00| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-09-22 06:23:19+00:00| /sw/gpgpu/libcudacxx/libcxx/include/array:502:12: error: explicit specialization of non-template struct 'tuple_element'
2022-09-22 06:23:19+00:00| struct tuple_element<_Ip, _CUDA_VSTD::array<_Tp, _Size>>
2022-09-22 06:23:19+00:00| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-09-22 06:23:19+00:00| In file included from /sw/gpgpu/libcudacxx/libcxx/src/filesystem/operations.cpp:10:
2022-09-22 06:23:19+00:00| /sw/gpgpu/libcudacxx/libcxx/include/array:497:12: error: explicit specialization of non-template struct 'tuple_size'
2022-09-22 06:23:19+00:00| struct tuple_size<_CUDA_VSTD::array<_Tp, _Size>>
2022-09-22 06:23:19+00:00| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-09-22 06:23:19+00:00| /sw/gpgpu/libcudacxx/libcxx/include/array:502:12: error: explicit specialization of non-template struct 'tuple_element'
2022-09-22 06:23:19+00:00| struct tuple_element<_Ip, _CUDA_VSTD::array<_Tp, _Size>>
2022-09-22 06:23:19+00:00| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-09-22 06:23:19+00:00| 1 warning and 2 errors generated.
There was a problem hiding this comment.
But the forward declaration is like directly above. How can that fail?
| template<size_t _Ip, class... _Tp> | ||
| struct tuple_element<_Ip, _CUDA_VSTD::tuple<_Tp...>> | ||
| : _CUDA_VSTD::tuple_element<_Ip, _CUDA_VSTD::tuple<_Tp...>> | ||
| {}; |
There was a problem hiding this comment.
Same as other comment:
2022-09-22 06:23:19+00:00| In file included from /sw/gpgpu/libcudacxx/libcxx/include/utility:200:
2022-09-22 06:23:19+00:00| /sw/gpgpu/libcudacxx/libcxx/include/__tuple:574:12: error: explicit specialization of non-template struct 'tuple_size'
2022-09-22 06:23:19+00:00| struct tuple_size<_CUDA_VSTD::tuple<_Tp...>>
2022-09-22 06:23:19+00:00| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-09-22 06:23:19+00:00| /sw/gpgpu/libcudacxx/libcxx/include/__tuple:579:12: error: explicit specialization of non-template struct 'tuple_element'
2022-09-22 06:23:19+00:00| struct tuple_element<_Ip, _CUDA_VSTD::tuple<_Tp...>>
2022-09-22 06:23:19+00:00| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
There are even worse ones That would require us to specialize depending on host library |
miscco
force-pushed
the
tuple_structured_bindings
branch
2 times, most recently
from
5b1799e to
9493cf5
Compare
griwes
reviewed
Sep 27, 2022
Currently structured bindings for `cuda::std::tuple` and `cuda::std::array` was broken. The reason for that is that the standard requires, that the specializations of `tuple_size` and `tuple_element` reside in namespace std. whereas our specializations resided in namespace `cuda::std` Work around that by pulling those specializations into namespace std too. Fixes CUDA Tuple Structured Binding Declaration Broken NVIDIA#316
miscco
force-pushed
the
tuple_structured_bindings
branch
from
ea09d2d to
466facb
Compare
|
@griwes this passed internal CI and I believe your comments are addressed. Can we merge this? |
wmaxey
added
testing: internal ci passed
wmaxey
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently structured bindings for
cuda::std::tupleandcuda::std::arraywere broken.The reason for that is that the standard requires, that the specializations of
tuple_sizeandtuple_elementreside in namespace std. whereas our specializations resided in namespacecuda::stdWork around that by pulling those specializations into namespace std too.
Fixes CUDA Tuple Structured Binding Declaration Broken #316