This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix gcc12 issues #318
Merged
Fix gcc12 issues #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc complains that there are already functions named `read` and `write` defined. Where do you ask. I have no idea and rather than spending ages searching for them rename the two structs
It seems their implementation is finally mature enough to pass the test
So mark those tests as XFAIL in case we ever implement it
griwes
reviewed
Sep 27, 2022
.upstream-tests/test/std/utilities/time/time.clock/time.clock.system/local_time.types.pass.cpp
Show resolved
Hide resolved
griwes
approved these changes
Sep 27, 2022
|
Squashing and merging! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a host of gcc12 issues that are coming up in CI
Fixes nvbug3764574