KEMBAR78
Modularize <functional> by miscco · Pull Request #355 · NVIDIA/libcudacxx · GitHub
Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Modularize <functional> #355

Merged
merged 20 commits into from
Mar 1, 2023
Merged

Modularize <functional> #355

merged 20 commits into from
Mar 1, 2023

Conversation

@miscco
Copy link
Collaborator

@miscco miscco commented Jan 23, 2023

This modularizes functional into a host of small header files and makes them usable internally

@miscco miscco force-pushed the modularize_utility branch from 5d38c3f to bc38995 Compare January 23, 2023 16:42
@miscco miscco force-pushed the modularize_functional branch from 214f4dc to a1b7f12 Compare January 23, 2023 16:42
@miscco miscco force-pushed the modularize_utility branch from bc38995 to 0cc8ff1 Compare February 9, 2023 14:37
@miscco miscco force-pushed the modularize_functional branch 2 times, most recently from 319614a to 7c68ed1 Compare February 13, 2023 09:37
@miscco miscco force-pushed the modularize_utility branch 2 times, most recently from 7b401d4 to e7179a5 Compare February 14, 2023 09:03
@miscco miscco force-pushed the modularize_functional branch from 7c68ed1 to f1667c6 Compare February 14, 2023 09:03
@miscco miscco added the testing: internal ci passed Passed internal NVIDIA CI (DVS). label Feb 14, 2023
@miscco miscco force-pushed the modularize_utility branch from e7179a5 to ad92f94 Compare February 16, 2023 15:13
@miscco miscco force-pushed the modularize_functional branch from f1667c6 to a6ec7af Compare February 16, 2023 15:13
@miscco miscco force-pushed the modularize_utility branch from ad92f94 to b0e802c Compare February 16, 2023 19:52
@miscco miscco force-pushed the modularize_functional branch 2 times, most recently from 7f03d91 to 0534343 Compare February 16, 2023 20:00
@miscco miscco force-pushed the modularize_utility branch from b0e802c to cd13c4b Compare February 16, 2023 20:00
@miscco miscco changed the base branch from modularize_utility to main February 20, 2023 11:02
@miscco miscco force-pushed the modularize_functional branch from 0534343 to 7722c0c Compare February 20, 2023 11:04
@miscco miscco requested review from griwes and wmaxey February 21, 2023 09:18
@miscco miscco force-pushed the modularize_functional branch from 7722c0c to 91e3674 Compare February 21, 2023 09:29
@wmaxey
Copy link
Member

wmaxey commented Feb 27, 2023

There are some failures on MSVC caused by the implicit/explicit constructors being enabled both at once.

C:\Users\Wes\Documents\workspace\libcudacxx\include\cuda\std\detail\libcxx\include\__functional\../__utility/pair.h(208): error C2535: 'cuda::std::__4::pair<_T1,_T2>::pair(const _T1 &,const _T2 &) noexcept(<expr>)': member function already defined or declared
C:\Users\Wes\Documents\workspace\libcudacxx\include\cuda\std\detail\libcxx\include\__functional\../__utility/pair.h(199): note: see declaration of 'cuda::std::__4::pair<_T1,_T2>::pair'
C:\Users\Wes\Documents\workspace\libcudacxx\include\cuda\std\detail\libcxx\include\__functional\../__utility/pair.h(439): note: see reference to class template instantiation 'cuda::std::__4::pair<_T1,_T2>' being compiled
C:\Users\Wes\Documents\workspace\libcudacxx\include\cuda\std\detail\libcxx\include\__functional\../__utility/pair.h(312): error C2535: 'cuda::std::__4::pair<_T1,_T2>::pair(_Tuple &&)': member function already defined or declared
C:\Users\Wes\Documents\workspace\libcudacxx\include\cuda\std\detail\libcxx\include\__functional\../__utility/pair.h(304): note: see declaration of 'cuda::std::__4::pair<_T1,_T2>::pair'

miscco and others added 2 commits February 28, 2023 15:42
@miscco
Fix compilation issues with MSVC
4888737 
`_D1` and `_D2` are macros defined in MSVC xmath.hpp

#fixes Missing symbols in MSVC C++ compilation, many headers fail to compile #354
@wmaxey @miscco
Fix missing abort in unreachable.h
bd8eee2
@miscco miscco force-pushed the modularize_functional branch from af633bb to bd8eee2 Compare February 28, 2023 14:43
@wmaxey wmaxey merged commit d714668 into main Mar 1, 2023
@wmaxey wmaxey deleted the modularize_functional branch March 1, 2023 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@griwes griwes Awaiting requested review from griwes

1 more reviewer

@wmaxey wmaxey wmaxey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing: internal ci passed Passed internal NVIDIA CI (DVS).

Projects

CCCL
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miscco @wmaxey