KEMBAR78
Enable `is_constant_evaluated` in c++11 by wmaxey · Pull Request #76 · NVIDIA/libcudacxx · GitHub
Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Conversation

@wmaxey
Copy link
Member

@wmaxey wmaxey commented Nov 17, 2020

This seems acceptable to backport and will be useful for constexpr <complex>.

We test on the builtin being available, however, in some compiler versions it won't be depending on host+NVCC combination.

We should also look into exposing feature test macros with some mechanism similar to <version>

@wmaxey wmaxey requested review from griwes and jrhemstad November 17, 2020 09:27
@wmaxey wmaxey force-pushed the feature/backport_is_const_eval branch from 7e1b71f to e1da50d Compare November 18, 2020 00:57
@wmaxey wmaxey force-pushed the feature/backport_is_const_eval branch from e1da50d to 6e49553 Compare November 18, 2020 01:00
@wmaxey
Copy link
Member Author

wmaxey commented Nov 18, 2020

CI is clean and fixes several old failures. 29334943

@wmaxey wmaxey merged commit 0bebd4f into NVIDIA:main Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants