KEMBAR78
Comparing v1.17.7...v1.17.8 · NVIDIA/libnvidia-container · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NVIDIA/libnvidia-container
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.17.7
Choose a base ref
...
head repository: NVIDIA/libnvidia-container
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.17.8
Choose a head ref
  • 8 commits
  • 4 files changed
  • 2 contributors

Commits on May 15, 2025

  1. [no-relnote] Add SECURITY.md to repo

    Signed-off-by: Evan Lezar <elezar@nvidia.com>
    elezar committed May 15, 2025
    Configuration menu
    Copy the full SHA
    d636242 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #309 from elezar/add-security-md

    [no-relnote] Add SECURITY.md to repo
    elezar authored May 15, 2025
    Configuration menu
    Copy the full SHA
    51a7f20 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2025

  1. Do not discard container flags when --cuda-compat-mode is not specified

    Signed-off-by: Jamie Liu <jamieliu@google.com>
    nixprime committed May 16, 2025
    Configuration menu
    Copy the full SHA
    63eb489 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2025

  1. Merge pull request #310 from nixprime/main

    Do not discard container flags when --cuda-compat-mode is not specified
    
    In the case where no cuda-compat-mode was specified on the nvidia-container-cli configure commandline, the calculated set of flags were being CLEARED instead of setting a single bit.
    
    This change ensures that the correct bit is set and the remaining bits are left unchanged.
    
    This was not affecting the nvidia-container-runtime-hook's usage of the nvidia-container-cli since we explicitly add flags in that case.
    elezar authored May 20, 2025
    Configuration menu
    Copy the full SHA
    ebabd2a View commit details
    Browse the repository at this point in the history
  2. Add additional logging

    This change adds additional logging around the flags and the
    cuda-compat-mode option.
    
    Signed-off-by: Evan Lezar <elezar@nvidia.com>
    elezar committed May 20, 2025
    Configuration menu
    Copy the full SHA
    4ac868a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #311 from elezar/bugfix-enroot

    Add additional logging
    elezar authored May 20, 2025
    Configuration menu
    Copy the full SHA
    caf057b View commit details
    Browse the repository at this point in the history

Commits on May 28, 2025

  1. Fix pointer accessing local variable out of scope

    The C11 standard states that the value of a pointer is undefined
    outside of its lifetime. Since we were initilizing the argv pointer
    in two conditional blocks, compilers that implement this standard were
    cleaning up the value and this caused invalid dereferences of the
    pointer.
    
    The change introduces two local variables with the same lifetime of the
    argv pointer and assigns these in the conditional blocks instead.
    
    Signed-off-by: Evan Lezar <elezar@nvidia.com>
    elezar committed May 28, 2025
    Configuration menu
    Copy the full SHA
    9e08681 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #318 from elezar/fix-initialization-in-branch

    Fix pointer accessing local variable out of scope
    elezar authored May 28, 2025
    Configuration menu
    Copy the full SHA
    6eda4d7 View commit details
    Browse the repository at this point in the history
Loading