KEMBAR78
[Fix] rewrite the benchmark to test each API separately. by jiashuy · Pull Request #113 · NVIDIA-Merlin/HierarchicalKV · GitHub
Skip to content

Conversation

@jiashuy
Copy link
Collaborator

@jiashuy jiashuy commented Apr 2, 2023

  1. rewrite the benchmark to test each API separately.
  2. add insert_and_evict API to the benchmark.
  3. update the README.md according to the benchmark.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

@jiashuy jiashuy requested a review from rhdong April 2, 2023 10:56
@rhdong rhdong requested a review from Lifann April 2, 2023 12:20
@rhdong
Copy link
Member

rhdong commented Apr 28, 2023

/blossom-ci

2 similar comments
@rhdong
Copy link
Member

rhdong commented Apr 28, 2023

/blossom-ci

@rhdong
Copy link
Member

rhdong commented Apr 28, 2023

/blossom-ci

Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 453b1b0 into NVIDIA-Merlin:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants