[Refactor] lock free with Locked key #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rhdong
commented
Apr 28, 2023
rhdong
commented
- Change insert/assign/evict like API to use unique lock, and find use shared_lock
- Optimize the tests package name
- Fix: [BUG] export_batch get not expected value when max_capacity is smaller than insert data length. #118
|
/blossom-ci |
rhdong
force-pushed
the
rhdong/locked-key
branch
from
bccb3ce to
684b1a3
Compare
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-120 |
rhdong
commented
Apr 28, 2023
rhdong
force-pushed
the
rhdong/locked-key
branch
from
684b1a3 to
e327105
Compare
rhdong
commented
May 4, 2023
Lifann
reviewed
May 4, 2023
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
- Change insert/assign/evict like API to use unique lock, and find use shared_lock - Optimize the tests package name - Fix: NVIDIA-Merlin#118 d1
rhdong
force-pushed
the
rhdong/locked-key
branch
2 times, most recently
from
f0d5273 to
f4ba9b9
Compare
|
Some issues of blossom caused a fail trigger CI workflow. We ran the CI testing manually and passed it successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.