KEMBAR78
[Feat] make allocator customizable by rhdong · Pull Request #145 · NVIDIA-Merlin/HierarchicalKV · GitHub
Skip to content

Conversation

rhdong
Copy link
Member

@rhdong rhdong commented Jun 22, 2023

No description provided.

@rhdong rhdong requested review from Lifann and zhangyafeikimi June 22, 2023 09:29
@github-actions
Copy link

@rhdong
Copy link
Member Author

rhdong commented Jun 22, 2023

/blossom-ci

@rhdong
Copy link
Member Author

rhdong commented Jun 23, 2023

/blossom-ci

@rhdong rhdong force-pushed the rhdong/allocator2 branch from 553562f to 16c8c68 Compare June 26, 2023 13:02
@rhdong
Copy link
Member Author

rhdong commented Jun 26, 2023

/blossom-ci

@rhdong rhdong force-pushed the rhdong/allocator2 branch from 16c8c68 to ab9b953 Compare July 26, 2023 14:04
@rhdong
Copy link
Member Author

rhdong commented Jul 26, 2023

/blossom-ci

Lifann
Lifann previously approved these changes Jul 27, 2023
Copy link
Collaborator

@Lifann Lifann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numerical check passed for me.

@rhdong rhdong closed this Jul 27, 2023
@rhdong rhdong reopened this Jul 27, 2023
@rhdong rhdong dismissed Lifann’s stale review July 27, 2023 07:03

The merge-base changed after approval.

@rhdong rhdong force-pushed the rhdong/allocator2 branch from ab9b953 to 1be8572 Compare July 27, 2023 07:03
@rhdong
Copy link
Member Author

rhdong commented Jul 27, 2023

/blossom-ci

1 similar comment
@rhdong
Copy link
Member Author

rhdong commented Jul 27, 2023

/blossom-ci

@rhdong rhdong requested review from jiashuy and removed request for zhangyafeikimi July 27, 2023 07:10
Copy link
Collaborator

@Lifann Lifann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 0da72d4 into NVIDIA-Merlin:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants