KEMBAR78
[Fix] make thrust temp memory allocation managed by HKV allocator. by rhdong · Pull Request #178 · NVIDIA-Merlin/HierarchicalKV · GitHub
Skip to content

Conversation

rhdong
Copy link
Member

@rhdong rhdong commented Oct 15, 2023

No description provided.

@rhdong rhdong requested a review from LinGeLin October 15, 2023 04:35
@rhdong rhdong force-pushed the rhdong/thrust-allocator branch from 11a1c7d to 3b8ed85 Compare October 15, 2023 04:36
@rhdong
Copy link
Member Author

rhdong commented Oct 15, 2023

/blossom-ci

@github-actions
Copy link

@rhdong rhdong force-pushed the rhdong/thrust-allocator branch 2 times, most recently from 1d0dc9c to 30bef74 Compare October 24, 2023 03:45
- Refactoring: clean the warning on low version of CUDA
@rhdong rhdong force-pushed the rhdong/thrust-allocator branch from 30bef74 to 5dfba55 Compare October 24, 2023 03:47
@rhdong
Copy link
Member Author

rhdong commented Oct 24, 2023

/blossom-ci

@rhdong rhdong requested a review from jiashuy October 24, 2023 03:50
Copy link
Collaborator

@LinGeLin LinGeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
};

#if defined(CUDART_VERSION) && (CUDART_VERSION >= 11030)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jiashuy, I cleaned some TLPv2 warnings we discussed before. Please help review and confirm. Thanks!

@rhdong rhdong merged commit 5301c4a into NVIDIA-Merlin:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants