KEMBAR78
[Docs] Fix incorrectly formatted reference tags by erastorgueva-nv · Pull Request #13445 · NVIDIA-NeMo/NeMo · GitHub
Skip to content

Conversation

@erastorgueva-nv
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix some reference tags.

Collection: Docs

Changelog

  • small docs fixes

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • [ N/A ] Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • [ N/A ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Some of the errors were accidentally introduced in Update flagged docs links #13391. Incorrectly-formatted reference tags did not get turned into links, hence linkcheck did not pick up the errors.

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
@github-actions github-actions bot added the ASR label May 5, 2025
Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
@github-actions github-actions bot added the TTS label May 5, 2025
Please refer to the model page of :ref:`Conformer-Transducer <Conformer-Transducer_model>` for more information on this model.

.. _asr-configs-lstm-transducer-and-ctc
.. _asr-configs-lstm-transducer-and-ctc:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing's referencing these links right now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chtruong814
Copy link
Collaborator

@erastorgueva-nv let me know if you want another of your team member to review. Otherwise, i can just merge this for you.

@erastorgueva-nv
Copy link
Collaborator Author

@erastorgueva-nv let me know if you want another of your team member to review. Otherwise, i can just merge this for you.

No need for additional review. Please merge.

@chtruong814 chtruong814 merged commit a0a9311 into main May 7, 2025
34 checks passed
@chtruong814 chtruong814 deleted the erastorgueva/docs_fixes branch May 7, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants