Patch: r2.5.0 with onelogger changes. #14811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Patch release r2.5.0 with changes related to nv-one-logger which enable NeMo using OneLogger for job performance instrumentation.
Original PR !13437
Collection: [Note which collection this PR will affect]
Will keep updating
Changelog
CallbackGroupandCallbackABC inNeMo/nemo/lightning/pytorch/callbacks/callback_group.pyandbase_callback.pyused by various collections.collections/llmtryfinallylogic for trainer incollections/llm/api.pyto ensure theon_app_end()call is always called.__init_subclass__method to ensure the callbacks are hooked incollections/llm/fn/mixin.py.collections/llm/modelopt/speculative/model_transform.py.collections/llm/gpt/data/mock.py,collections/llm/t5/data/mock.py.collections/speechlm2optim_setup.py.collections/vlmon_dataloader_init_start/end()instrumentation hook call inpreloaded.py.collections/coreone_model_init_start/end()on_dataloader_init_start/end(),on_load_checkpoint_start/end()instrumentation hook call inmodelPT.py.optimizer_nameinmodelPT.py.finallyto make sure with exception in_run_hydrastill instrumenton_app_end().optim/lr_scheduler.pyoptim/optimizers.pycollections/lightningcallbackrelated classes.OneLoggermodule for lightning boot up incollections/lightning/io/mixin.pymodel_checkpoint.pywhich result in pipeline failure incollections/lightning/pytorch/callbacks.testsUsage
Not changed.
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information