cp: Fix the load checkpointing issue -- onelogger callback gets called multiple time in some case. (14945) into r2.5.0
#14948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple time in some case. (#14945) * Update modelPT.py Signed-off-by: Jiashang Hu <jiashangh@nvidia.com> * Update one_logger_callback.py Signed-off-by: Jiashang Hu <jiashangh@nvidia.com> * fix the test for error handling Signed-off-by: Jiashang Hu <jiashangh@nvidia.com> * update the dependency version Signed-off-by: Jiashang Hu <jiashangh@nvidia.com> --------- Signed-off-by: Jiashang Hu <jiashangh@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
|
LGTM approved as MLWFO |
|
The import test is failing because of how the workflow is written using the main branch instead to verify dependency installs. Will go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @liquor233 👋,