KEMBAR78
feat: Parallelized worker initialization by SahilJain314 · Pull Request #452 · NVIDIA-NeMo/RL · GitHub
Skip to content

Conversation

@SahilJain314
Copy link
Contributor

What does this PR do ?

Speeds up setup time. Each worker was initialized somewhat serially before.

Signed-off-by: Sahil Jain <sahilj@nvidia.com>
@SahilJain314 SahilJain314 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels May 28, 2025
parthchadha
parthchadha previously approved these changes May 28, 2025
terrykong
terrykong previously approved these changes May 28, 2025
@terrykong terrykong added this pull request to the merge queue May 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2025
@SahilJain314 SahilJain314 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jun 3, 2025
@parthchadha parthchadha dismissed stale reviews from terrykong and themself via 0f2e113 June 3, 2025 18:13
@SahilJain314 SahilJain314 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jun 3, 2025
@SahilJain314 SahilJain314 added this pull request to the merge queue Jun 4, 2025
@parthchadha parthchadha merged commit 0f2e113 into main Jun 4, 2025
21 of 23 checks passed
@parthchadha parthchadha deleted the sahilj/parallel_init branch June 4, 2025 01:04
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to it being already merged Jun 4, 2025
@SahilJain314 SahilJain314 restored the sahilj/parallel_init branch June 4, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants