perf: Avoid creating new typeface instances for system fonts

CatchABus · NathanWalker · commit 4902e2781887 · 2025-01-28T23:26:24.000-08:00
diff --git a/packages/core/ui/styling/font.android.ts b/packages/core/ui/styling/font.android.ts
@@ -41,7 +41,7 @@ export class Font extends FontBase {
 
 	getAndroidTypeface(): android.graphics.Typeface {
 		if (!this._typeface) {
-			this._typeface = createTypeface(this);
+			this._typeface = SDK_VERSION >= 28 ? createTypeface(this) : createTypefaceLegacy(this);
 		}
 
 		return this._typeface;
@@ -120,25 +120,58 @@ function loadFontFromFile(fontFamily: string, font: Font): android.graphics.Type
 
 function createTypeface(font: Font): android.graphics.Typeface {
 	const fontFamilies = parseFontFamily(font.fontFamily);
-	const fontWeight = font.fontWeight;
-	const isNumericFontWeightSupported = SDK_VERSION >= 28;
+	const fontWeightNum = getNumericFontWeight(font.fontWeight);
 
 	let result: android.graphics.Typeface;
-	let fontStyle: number = 0; // This will be empty if numeric font weight is supported
-	// https://stackoverflow.com/questions/19691530/valid-values-for-androidfontfamily-and-what-they-map-to
-	let fontSuffix: string;
 
-	if (isNumericFontWeightSupported) {
-		fontSuffix = '';
-	} else {
-		if (font.isBold) {
-			fontStyle |= android.graphics.Typeface.BOLD;
+	for (const fontFamily of fontFamilies) {
+		switch (fontFamily.toLowerCase()) {
+			case genericFontFamilies.serif:
+				result = android.graphics.Typeface.create(android.graphics.Typeface.SERIF, fontWeightNum, font.isItalic);
+				break;
+			case genericFontFamilies.sansSerif:
+			case genericFontFamilies.system:
+				result = android.graphics.Typeface.create(android.graphics.Typeface.SANS_SERIF, fontWeightNum, font.isItalic);
+				break;
+			case genericFontFamilies.monospace:
+				result = android.graphics.Typeface.create(android.graphics.Typeface.MONOSPACE, fontWeightNum, font.isItalic);
+				break;
+			default: {
+				result = loadFontFromFile(fontFamily, font);
+				if (result) {
+					result = android.graphics.Typeface.create(result, fontWeightNum, font.isItalic);
+				}
+				break;
+			}
 		}
-		if (font.isItalic) {
-			fontStyle |= android.graphics.Typeface.ITALIC;
+
+		// Found the font!
+		if (result) {
+			break;
 		}
+	}
+
+	if (!result) {
+		result = android.graphics.Typeface.create(android.graphics.Typeface.SANS_SERIF, fontWeightNum, font.isItalic);
+	}
+
+	return result;
+}
 
-		fontSuffix = getFontWeightSuffix(fontWeight);
+function createTypefaceLegacy(font: Font): android.graphics.Typeface {
+	const fontFamilies = parseFontFamily(font.fontFamily);
+	const fontWeight = font.fontWeight;
+	// https://stackoverflow.com/questions/19691530/valid-values-for-androidfontfamily-and-what-they-map-to
+	const fontSuffix = getFontWeightSuffix(fontWeight);
+
+	let result: android.graphics.Typeface;
+	let fontStyle: number = 0;
+
+	if (font.isBold) {
+		fontStyle |= android.graphics.Typeface.BOLD;
+	}
+	if (font.isItalic) {
+		fontStyle |= android.graphics.Typeface.ITALIC;
 	}
 
 	for (const fontFamily of fontFamilies) {
@@ -172,11 +205,6 @@ function createTypeface(font: Font): android.graphics.Typeface {
 		result = android.graphics.Typeface.create('sans-serif' + fontSuffix, fontStyle);
 	}
 
-	// Newer android versions can accept a numeric font weight
-	if (isNumericFontWeightSupported) {
-		result = android.graphics.Typeface.create(result, getNumericFontWeight(fontWeight), font.isItalic);
-	}
-
 	return result;
 }
 
