KEMBAR78
fix(ios): Incorrect background styles after frame changed by safe area by CatchABus · Pull Request #10661 · NativeScript/NativeScript · GitHub
Skip to content

Conversation

@CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Dec 18, 2024

PR Checklist

What is the current behavior?

During iOS rotation layout, some views end up with misaligned background/borders. That is because computation updates native view frame at a certain point and appends safe-area insets.
I attached screenshots from a yellow view with a bottom border.

Before screen rotation:
Screenshot 2024-12-18 at 6 48 54 PM

After screen rotation:
Screenshot 2024-12-18 at 6 49 17 PM

What is the new behavior?

Layout procedure will mark size as changed in case frame has been updated to include safe-area insets.
This PR also includes some cleanup regarding position types.

@NathanWalker NathanWalker merged commit 1e86ed9 into NativeScript:main Jan 13, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants