KEMBAR78
feat(core): Added flexibility for using multiple RootLayouts by CatchABus · Pull Request #10684 · NativeScript/NativeScript · GitHub
Skip to content

Conversation

@CatchABus
Copy link
Contributor

PR Checklist

What is the new behavior?

This PR adds flexibility for multiple RootLayouts and the getRootLayoutById function to retrieve one using its view id.
Core will keep a root layout stack just like it does with Frames.
Also, existing getRootLayout function will return the first RootLayout in the view tree.

Additionally:

  • Improved error messages
  • Fixed a problem that caused a shade cover with gradient not to switch to a colored one
  • Added iOS view disposal support to get rid of native gradient layer when needed
  • Now, shade cover will calculate its insert index based on existing popup views

@CatchABus CatchABus force-pushed the feat/multi-rootlayout branch from 7cee829 to 6f5e701 Compare January 31, 2025 22:39
@vallemar
Copy link
Contributor

vallemar commented Feb 1, 2025

I've wanted this for a long time! Nice!

@NathanWalker NathanWalker added this to the 8.9 milestone Feb 2, 2025
@NathanWalker NathanWalker merged commit 4b87a35 into NativeScript:main Feb 2, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants