fix: inner type should net be set when companion object is defined as function (#1831)

ammarahm-ed · web-flow · commit e293636ed1e9 · 2025-02-20T09:56:00.000-08:00
diff --git a/test-app/runtime/src/main/cpp/MetadataNode.cpp b/test-app/runtime/src/main/cpp/MetadataNode.cpp
@@ -859,11 +859,15 @@ void MetadataNode::SetInnerTypes(v8::Isolate* isolate, Local<Function>& ctorFunc
         auto context = isolate->GetCurrentContext();
         const auto &children = *treeNode->children;
         for (auto curChild: children) {
-            ctorFunction->SetAccessor(
-                    context,
-                    v8::String::NewFromUtf8(isolate, curChild->name.c_str()).ToLocalChecked(),
-                    InnerTypeAccessorGetterCallback, nullptr, v8::External::New(isolate, curChild)
-            );
+            bool hasOwnProperty = ctorFunction->HasOwnProperty(context, ArgConverter::ConvertToV8String(isolate, curChild->name)).ToChecked();
+                // Child is defined as a function already when the inner type is a companion object
+                if (!hasOwnProperty) {
+                    ctorFunction->SetAccessor(
+                        context,
+                        v8::String::NewFromUtf8(isolate, curChild->name.c_str()).ToLocalChecked(),
+                        InnerTypeAccessorGetterCallback, nullptr, v8::External::New(isolate, curChild)
+                );
+            }
         }
     }
 }
