Enable the new dependency resolver for lock files in the .NET 10 SDK #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
jeffkl
previously approved these changes
Feb 4, 2025
Nigusu-Allehu
previously approved these changes
Feb 4, 2025
jgonz120
previously approved these changes
Feb 5, 2025
src/NuGet.Core/NuGet.Commands/Utility/SdkAnalysisLevelMinimums.cs
Outdated
Show resolved
Hide resolved
nkolev92
dismissed stale reviews from jgonz120, Nigusu-Allehu, and jeffkl
via
d105872
Nigusu-Allehu
approved these changes
Feb 5, 2025
jgonz120
approved these changes
Feb 5, 2025
jeffkl
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Related: NuGet/Home#13800
Description
We're not sure when we're enabling NuGet/Home#13800 yet.
This PR does halfway of the re-enabling of the new algo for lock files by enabling it for the .NET 10 SDK.
Pruning is only implemented in the new resolver, so without this change, you can't use pruning + lock files, and it was blocking all my tests and the work on NuGet/Home#14075.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.