[API compatibility] add the param name for paddle.Tensor.copy_ #74768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Aug 20, 2025
paddle/fluid/pybind/eager_method.cc
Outdated
| "sure you are on the right way. " | ||
| "The expected arguments as follow: (" | ||
| "other, non_blocking)")); | ||
| PADDLE_ENFORCE_EQ( |
paddle/fluid/pybind/eager_method.cc
Outdated
| common::errors::PreconditionNotMet( | ||
| "Must provide the `other: Tensor` params for paddle.Tensor.copy_")); | ||
|
|
||
| paddle::Tensor& src_tensor = CastPyArg2Tensor(other, 0); |
paddle/fluid/pybind/eager_method.cc
Outdated
| EAGER_TRY | ||
| paddle::Tensor& src_tensor = CastPyArg2Tensor(PyTuple_GET_ITEM(args, 0), 0); | ||
| PyObject* other = nullptr; | ||
| bool blocking = false; |
There was a problem hiding this comment.
之前使用paddle并指定blocking的代码会挂掉，这个要兼容的话 就是在blocking后面加1个non_blocking参数，只有torch的non_blocking未指定关键字时被误当做blocking，这个影响应比较小。
other, blocking, non_blocking
There was a problem hiding this comment.
嗯？是指.copy_(a, blocking=True)这个调用会报错吗，如果是的话应该是因为之前的copy_里面只对args解析了，没有对kwargs进行解析所以会报错。如果是.copy_(a, True, non_blocking=True)，这种情况，以non_blocking为主吗？
zeroRains
commented
Aug 22, 2025
| nullptr}; | ||
| bool flag = PyArg_ParseTupleAndKeywords( | ||
| args, kwargs, "|Obb", kwlist, &other_tensor, &blocking, &non_blocking); | ||
| blocking = !blocking || non_blocking ? false : true; |
There was a problem hiding this comment.
这个blocking设置的逻辑是，默认采用blocking的方式执行，只blocking参数为False或者non_blocking设置为True时，就使用non_blocking的方式执行
zhwesky2010
approved these changes
Aug 22, 2025
SigureMo
approved these changes
Aug 22, 2025
|
/re-run all-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
对齐paddle.Tensor.copy_与torch.Tensor.copy_。
当前paddle.Tensor.copy_已经存在，并且在功能上与torch.Tensor.copy_对齐，但是在paddle内是基于pybind实现的方法，在参数处理上没有处理kwargs的逻辑并且没有返回值（torch里有返回值），本PR进行了补充与完善。
在PaConvert下自测，paddle.Tensor.copy_与torch.Tenso.copy_对齐。
pcard-71500