[API Compatibility] add out for topk
#74887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74887 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 9
Branches ? 0
===========================================
Hits ? 9
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
zhwesky2010
approved these changes
Aug 27, 2025
| out_values, out_indices = out | ||
| out_values = paddle.assign(values, output=out_values) | ||
| out_indices = paddle.assign(indices, output=out_indices) | ||
| return out_values, out_indices |
There was a problem hiding this comment.
下个PR可以看下这个返回类型的问题：torch的返回类型是torch.return_types.topk
我们针对这个也封装了相应数据结构：https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/tensor/compat.py#L222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
topk增加别名装饰器，使用assign来实现out参数；
amaxamin在之前已经完成了下沉，这个pr补充文档、单测pcard-71500