Add join() function #1086
Merged
Add join() function #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested changes
Aug 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new join() function to DSC that concatenates array elements or string characters using a delimiter. The implementation includes comprehensive documentation and test coverage.
Key changes:
- Adds
join()function implementation with support for arrays and strings - Includes localization strings for error messages and descriptions
- Provides comprehensive documentation with examples and parameter details
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dsc_lib/src/functions/mod.rs | Registers the new join module and function in the dispatcher |
| dsc_lib/src/functions/join.rs | Implements the join function with array and string support |
| dsc_lib/locales/en-us.toml | Adds localized strings for join function messages |
| dsc/tests/dsc_functions.tests.ps1 | Adds test cases for join function behavior |
| docs/reference/schemas/config/functions/join.md | Provides comprehensive documentation with examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Gijsreyn
force-pushed
the
add-join-function
branch
from
56b21d7 to
79f8e32
Compare
|
You might wait til after the |
|
@Gijsreyn you can address the conflicts now |
…into add-join-function
SteveL-MSFT
requested changes
Sep 3, 2025
SteveL-MSFT
requested changes
Sep 4, 2025
SteveL-MSFT
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request adds the join() function, including reference documentation.
PR Context
Partially addresses #57