Make PS-Committee reviewed experimental features stable #15864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Aug 4, 2021
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
iSazonov
added
the
CL-General
iSazonov
approved these changes
Aug 4, 2021
| resultText = resultText.TrimEnd(); | ||
|
|
||
| if (ExperimentalFeature.IsEnabled("PSAnsiRendering")) | ||
| var text = new ValueStringDecorated(resultText); |
There was a problem hiding this comment.
Side note: the struct could be readonly struct.
There was a problem hiding this comment.
making the struct readonly requires making the fields readonly which breaks the deferred creation of PlainText only when needed
There was a problem hiding this comment.
LazyInitializer could be used for PlainText.
|
CodeQL issue appears to have been fixed recently by GitHub in their action: github/codeql-action@a00769b#diff-5bd808ec74194675da6319beb80c228163039f26c9ddf1b8bf3eef9b12c9341bR490 |
rjmholt
approved these changes
Aug 9, 2021
22 tasks
14 tasks
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Merged
22 tasks
5 tasks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Each commit makes a feature non-experimental (although one extra due to my filter only looking at .cs files initially...). Removed the advertising of the experimental feature and any code and tests that checked that the feature is enabled.
To avoid the headache of merge conflicts, I'm submitting this as a single PR.
PR Context
Fix #15862
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).