KEMBAR78
Add support for new WDAC API by PaulHigin · Pull Request #17247 · PowerShell/PowerShell · GitHub
Skip to content

Conversation

@PaulHigin
Copy link
Contributor

PR Summary

Implement new WDAC policy script file block option.

PR Context

WDAC API now supports the ability to allow/block PowerShell script files, whereas before the option was only to allow full/constrained language modes. This PR implements the new API with fallback to original system lock down behavior.

PR Checklist

@PaulHigin PaulHigin requested a review from anamnavi May 3, 2022 16:40
@PaulHigin PaulHigin requested a review from TravisEz13 as a code owner May 3, 2022 16:40
@PaulHigin PaulHigin self-assigned this May 3, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label May 13, 2022
@ghost
Copy link

ghost commented May 13, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@PaulHigin
Copy link
Contributor Author

Ping - @anamnavi, @TravisEz13, @daxian-dbw

@ghost ghost removed the Review - Needed The PR is being reviewed label May 13, 2022
@daxian-dbw
Copy link
Member

Sorry for the delay. Will do the review next Monday 😄

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor comment.

…ngs.resx

Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@pull-request-quantifier-deprecated

This PR has 126 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Medium
Size       : +113 -13
Percentile : 45.2%

Total files changed: 5

Change summary by file extension:
.cs : +106 -12
.resx : +6 -0
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@PaulHigin PaulHigin merged commit f6ac9bb into PowerShell:master May 16, 2022
@PaulHigin PaulHigin deleted the new-wdac branch May 16, 2022 21:18
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13
Copy link
Member

There was a breaking change in Windows 11 22H2 related to this feature which defaults CI script policy to block. We should not backport this to 7.2 until we verify that this issue has been resolved.

@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants